ux: return better error message if a segment doesn't exist #4122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds error handling to the segment store in cases where the ID isn't a valid postgres integer. This causes it to return a BadDataError instead of throwing an uncaught Error. As a bonus, we also catch cases where the row doesn't exist and populate that error message with more info: it now says that a segment with <id> doesn't exist instead of just 'No row'.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjaanus
reviewed
Jun 30, 2023
sjaanus
approved these changes
Jun 30, 2023
thomasheartman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch cases where the segment doesn't exist and populate that error message with more info: it now says that a segment
with doesn't exist instead of just 'No row'.