Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: demo flow with split strategy button by making step optional #4125

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Jun 30, 2023

This fixes the demo flow by making the strategy popup step optional.

This way the demo works whether the flag is enabled or not. Once we make the split strategy button GA, we can remove this step entirely.

Feel free to re-enable the flag once this is deployed to demo.

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 10:00am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jun 30, 2023 10:00am

Copy link
Contributor

@nicolaesocaciu nicolaesocaciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nunogois nunogois merged commit 5dcb0f1 into main Jun 30, 2023
19 checks passed
@nunogois nunogois deleted the fix-demo-flow-split-strategy-button branch June 30, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants