fix: improve users search #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
gastonfournier
approved these changes
Jul 4, 2023
nunogois
added a commit
that referenced
this pull request
Jul 5, 2023
https://linear.app/unleash/issue/2-1187/fix-two-extra-columns-in-users-list This fixes a regression introduced in #4131 where two extra columns were added for search only but were not properly hidden. Thanks @nicolaesocaciu for the heads up! Before:  After: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1183/improve-users-list-search
This adapts the users list to use the new
useSearchhook so you can have a better search that also includes "username" and "email" as fields. It's also more extensible in case we'd like to add filters in the future.