openapi: update API tokens tag #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
kwasniew
approved these changes
Jul 4, 2023
thomasheartman
commented
Jul 5, 2023
Comment on lines
+129
to
+138
| // it tells the user what happened | ||
| expect(result.description).toContain( | ||
| 'matches more than one option', | ||
| ); | ||
| // it tells the user what part of the request body this pertains to | ||
| expect(result.description).toContain( | ||
| dataPath === '.body' | ||
| ? 'root object' | ||
| : `${dataPath.substring('.body.'.length)} property`, | ||
| ); |
There was a problem hiding this comment.
Turns out that using multipling expect.stringContaining on an object property doesn't work 😬
sjaanus
reviewed
Jul 5, 2023
|
Good catch @sjaanus 🥇 |
thomasheartman
added a commit
that referenced
this pull request
Jul 5, 2023
Background (general): I don’t think it creates any value. I don’t think people check the snapshot explicitly (especially now that it’s so large that it gets hidden by default), and it only creates an extra chore that you forget to do all the time (at least I do). Background (why now?): I’ve been fighting a weird issue with the snapshot test for the [API tokens OpenAPI PR](#4137). The tests run fine locally, but fail in CI. The tests seem to be using an old version of the snapshot for the test. However, when I check the snapshot in the files tab, it’s got the new and correct values. I’ve spent probably more than an hour trying to fix and debug this today but to no avail.
thomasheartman
added a commit
that referenced
this pull request
Jul 6, 2023
Background (general): I don’t think it creates any value. I don’t think people check the snapshot explicitly (especially now that it’s so large that it gets hidden by default), and it only creates an extra chore that you forget to do all the time (at least I do). Background (why now?): I’ve been fighting a weird issue with the snapshot test for the [API tokens OpenAPI PR](#4137). The tests run fine locally, but fail in CI. The tests seem to be using an old version of the snapshot for the test. However, when I check the snapshot in the files tab, it’s got the new and correct values. I’ve spent probably more than an hour trying to fix and debug this today but to no avail.
thomasheartman
added a commit
that referenced
this pull request
Jul 6, 2023
Background (general): I don’t think it creates any value. I don’t think people check the snapshot explicitly (especially now that it’s so large that it gets hidden by default), and it only creates an extra chore that you forget to do all the time (at least I do). Background (why now?): I’ve been fighting a weird issue with the snapshot test for the [API tokens OpenAPI PR](#4137). The tests run fine locally, but fail in CI. The tests seem to be using an old version of the snapshot for the test. However, when I check the snapshot in the files tab, it’s got the new and correct values. I’ve spent probably more than an hour trying to fix and debug this today but to no avail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates endpoints and schemas for the API tokens tag.