-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hovering over feature shows full feature name #4138
Conversation
sjaanus
commented
Jul 4, 2023
•
edited
edited
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -65,4 +68,12 @@ export const LinkCell: FC<ILinkCellProps> = ({ | |||
) : ( | |||
<StyledWrapper>{content}</StyledWrapper> | |||
); | |||
|
|||
return withTooltip ? ( | |||
<Tooltip title={content} arrow describeChild> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather decorate LinkCell with a tooltip outside of this component
|
||
interface ILinkCellProps { | ||
title?: string; | ||
to?: string; | ||
onClick?: () => void; | ||
subtitle?: string; | ||
withTooltip?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd avoid adding those special case boolean flags for configuring components and compose instead.