Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure userId context exists when running demo #4144

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Jul 5, 2023

https://linear.app/unleash/issue/2-1168/demo-ensure-userid-context-field-in-setup-steps

This ensures that the userId context field exists when we reach specific demo topics that require it in order to be successfully completed. This uses the setup property on those topics, where we'll check for the existence of this context field and create it if it's not found.

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Jul 5, 2023 7:54am
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 5, 2023 7:54am

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we prevent it from being deleted instead?

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nunogois nunogois merged commit 8707c2f into main Jul 5, 2023
19 checks passed
@nunogois nunogois deleted the fix-demo-ensure-userid-context-exists branch July 5, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants