Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user openapi spec #4162

Merged
merged 2 commits into from
Jul 6, 2023
Merged

feat: user openapi spec #4162

merged 2 commits into from
Jul 6, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jul 6, 2023

About the changes

  • finishing users tag openapi spec
  • added missing descriptions to the Frontend SDK endpoints so that meta rules are satisfied

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 1:17pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 6, 2023 1:17pm

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple minor suggestions, but nothing major 🔥

src/lib/openapi/spec/feedback-schema.ts Show resolved Hide resolved
},
neverShow: {
description: 'Whether this feedback should be disabled',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean for feedback to be disabled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more precise description: true when user opts-in to never show the feedback again. This is UI only indicator to stop getting feedback prompt.

src/lib/openapi/spec/me-schema.ts Outdated Show resolved Hide resolved
src/lib/openapi/spec/profile-schema.ts Outdated Show resolved Hide resolved
src/lib/openapi/spec/proxy-client-schema.ts Outdated Show resolved Hide resolved
@kwasniew kwasniew merged commit d7b7d93 into main Jul 6, 2023
16 checks passed
@kwasniew kwasniew deleted the users-tag-openapi-spec branch July 6, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants