Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added service-account events #4164

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented Jul 6, 2023

We're using this in enterprise as well, so we need to add events that could happen there as well.

@chriswk chriswk self-assigned this Jul 6, 2023
@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 6, 2023 10:43am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jul 6, 2023 10:43am

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gastonfournier
Copy link
Contributor

Still, this requires changes on enterprise to depend on changes in OSS, not sure if this is ideal, but that can be a problem for later

@chriswk chriswk enabled auto-merge (squash) July 6, 2023 10:48
@chriswk chriswk merged commit 7130270 into main Jul 6, 2023
12 checks passed
@chriswk chriswk deleted the addMissingEnterpriseEvents branch July 6, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants