fix: project tokens can now be created with the correct permissions #4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sighphyre
commented
Jul 6, 2023
| const permissionRequired = tokenTypeToCreatePermission( | ||
| createToken.type, | ||
| ); | ||
| const permissionRequired = CREATE_PROJECT_API_TOKEN; |
There was a problem hiding this comment.
Creation of both frontend and client tokens use the same permission here. Seems to be a feature, not a bug so I've left it alone and allowed it to use that exact permission
sighphyre
commented
Jul 6, 2023
| }, | ||
| ]; | ||
|
|
||
| const hasAdminAccess = useHasRootAccess(ADMIN); | ||
| const hasCreateFrontendAccess = useHasRootAccess(CREATE_FRONTEND_API_TOKEN); | ||
| const hasCreateFrontendTokenAccess = useHasRootAccess(CREATE_PROJECT_API_TOKEN, project); |
There was a problem hiding this comment.
CREATE_PROJECT_API_TOKEN gives access to create both front end and client tokens so this is intentional
chriswk
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the creation of project only tokens (done through the project settings). When we redesigned the way tokens are created, we missed project specific tokens, which have their own permission set that wasn't respected. This forces only the project api for token creation to use the CREATE_PROJECT_API_TOKEN instead of the global CREATE_CLIENT_API_TOKEN or CREATE_FRONTEND_API_TOKEN