Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: project overview #4176

Merged
merged 5 commits into from
Jul 7, 2023
Merged

docs: project overview #4176

merged 5 commits into from
Jul 7, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jul 7, 2023

About the changes

Documenting project overview

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 9:39am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 9:39am

@@ -116,8 +116,18 @@ All default project strategies use the [gradual rollout activation strategy](act

Custom strategies are configured from each project's project settings tab.

<Figure caption="The default strategy configuration page is available from the project settings tab." img="/img/project-settings-default-sstrategy.png" />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken image because of a typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! This looks good to me 🥇 Got one minor suggestion for adding some missing words, but that's it. Kudos on the alt text for the image too; well done!

@@ -116,8 +116,18 @@ All default project strategies use the [gradual rollout activation strategy](act

Custom strategies are configured from each project's project settings tab.

<Figure caption="The default strategy configuration page is available from the project settings tab." img="/img/project-settings-default-sstrategy.png" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

website/docs/reference/projects.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
@kwasniew kwasniew merged commit 3ebf3c0 into main Jul 7, 2023
10 of 14 checks passed
@kwasniew kwasniew deleted the documents-project-overview branch July 7, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants