fix: bulk tags will work now with project permissions #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
commented
Jul 7, 2023
| @@ -85,6 +91,7 @@ export interface IFeatureProjectUserParams extends ProjectParam { | |||
|
|
|||
| const PATH = '/:projectId/features'; | |||
| const PATH_STALE = '/:projectId/stale'; | |||
| const PATH_TAGS = `/:projectId/tags`; | |||
There was a problem hiding this comment.
Now updating tags takes in projectId, so it can evaluate permissions.
sjaanus
commented
Jul 7, 2023
| @@ -74,7 +73,7 @@ class TagController extends Controller { | |||
| method: 'post', | |||
| path: '', | |||
| handler: this.createTag, | |||
| permission: UPDATE_FEATURE, | |||
| permission: NONE, | |||
There was a problem hiding this comment.
Removed project level permission to create tag, because it is not related to project/feature
kwasniew
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously creation of tags required UPDATE_FEATURE permission, but creating tags is not related to feature or project, so it was not able to work.
Also bulk update tags was missing projectId from url, so it also did not work properly.