Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add description to requests per seconds schemas #4182

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented Jul 7, 2023

What

Adds a quick and dirty description to requestPerSeconds and segmentedRequestPerSecondsSchema so the enterprise /rps endpoint has better API docs.

@chriswk chriswk added the docs Documentation label Jul 7, 2023
@chriswk chriswk self-assigned this Jul 7, 2023
@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 0:26am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 0:26am

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small language thing

Co-authored-by: Simon Hornby <liquidwicked64@gmail.com>
Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@chriswk chriswk merged commit 4ce78cc into main Jul 10, 2023
12 of 17 checks passed
@chriswk chriswk deleted the docs/rpsMetrics branch July 10, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants