fix: constraint validation affecting disabled button #4183
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| return hasValues || hasValue; |
There was a problem hiding this comment.
this is wrong. we were excluding locally invalid constraints from the remote check without saying those items are invalid
| Array.isArray(constraint.values) && | ||
| constraint.values.length > 0; | ||
| const hasValue = Boolean(constraint.value); | ||
| const invalidConstraints = constraints.find(item => !isValid(item)); |
There was a problem hiding this comment.
check locally invalid constraints that don't require server checks
There was a problem hiding this comment.
do we highlight what's wrong? it can be confusing when button is disabled and there is no validation error
| Array.isArray(constraint.values) && | ||
| constraint.values.length > 0; | ||
| const hasValue = Boolean(constraint.value); | ||
| const invalidConstraints = constraints.find(item => !isValid(item)); |
There was a problem hiding this comment.
do we highlight what's wrong? it can be confusing when button is disabled and there is no validation error
|
@Tymek previously we were not showing anything in this scenario. This is only when you add an empty constraint and try to submit it. When you try to save the constraint we have proper validation. |
About the changes
Fixing regression introduced by #3914.
We were not disabling save strategy or add to change request button on invalid constraints because we were filtering out invalid values locally in the frontend and excluding them from checking.
This PR fixes the regression and also introduces unit tests describing the new behavior.
Important files
Discussion points