Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: openapai favorite endpoints #4189

Merged
merged 8 commits into from
Jul 10, 2023
Merged

Conversation

andreas-unleash
Copy link
Contributor

Adds description and summary to favorite endpoints

About the changes

Closes # 1-1098

Important files

Discussion points

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 10, 2023 10:56am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jul 10, 2023 10:56am

@sjaanus
Copy link
Contributor

sjaanus commented Jul 10, 2023

Favorites e2e test should have strictSchemaValidation

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 💯 Some minor changes suggested before merging it, though.

src/lib/routes/admin-api/favorites.ts Outdated Show resolved Hide resolved
src/lib/routes/admin-api/favorites.ts Outdated Show resolved Hide resolved
src/lib/routes/admin-api/favorites.ts Outdated Show resolved Hide resolved
src/lib/routes/admin-api/favorites.ts Outdated Show resolved Hide resolved
andreas-unleash and others added 7 commits July 10, 2023 13:43
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚒

@andreas-unleash andreas-unleash merged commit d5ef1dd into main Jul 10, 2023
10 checks passed
@andreas-unleash andreas-unleash deleted the chore/openapi-favorites branch July 10, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants