feat: project UI rework, move edit and delete buttons deeper #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjaanus
commented
Jul 10, 2023
sjaanus
commented
- Move edit and delete buttons deeper
- Remove delete button from project list view
- Add feature counter and text indication to delete button, so it is more clear when and why project can be deleted
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjaanus
commented
Jul 10, 2023
There was a problem hiding this comment.
This file was leftover from past.
sjaanus
commented
Jul 10, 2023
| projectId: string, | ||
| newProjectPath: boolean | ||
| ) => { | ||
| return newProjectPath |
There was a problem hiding this comment.
Edit will be on new path
sjaanus
commented
Jul 10, 2023
| @@ -1 +1 @@ | |||
| export const formTemplateSidebarWidth = '27.5rem'; | |||
| export const formTemplateSidebarWidth = '36%'; | |||
There was a problem hiding this comment.
Together with @nicolaesocaciu we came up with new width for API sidebar.
sjaanus
commented
Jul 10, 2023
| featureCount: number; | ||
| } | ||
|
|
||
| export const DeleteProject = ({ |
There was a problem hiding this comment.
New component for project deletion
sjaanus
commented
Jul 10, 2023
| import PermissionButton from 'component/common/PermissionButton/PermissionButton'; | ||
| import ProjectForm from '../../ProjectForm/ProjectForm'; | ||
|
|
||
| const EditProject = () => { |
There was a problem hiding this comment.
This is refactored component out of old EditProject, but in future old EditProject will be deleted
ivarconr
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.