Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Datadog addon, ability to include source type name #4196

Merged
merged 2 commits into from
Jul 10, 2023
Merged

chore: Datadog addon, ability to include source type name #4196

merged 2 commits into from
Jul 10, 2023

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Jul 10, 2023 •
edited

About the changes

Include a new configuration parameter to be able to specify source_type_name. This is an opt-in feature which provides backward compatibility to our existing users.

image

Closes #4109

Discussion points

Maybe this should be hardcoded to Unleash but this gives additional flexibility

@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 10, 2023 1:09pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jul 10, 2023 1:09pm

@gastonfournier gastonfournier self-assigned this Jul 10, 2023
chriswk
chriswk approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastonfournier gastonfournier merged commit b37851a into main Jul 10, 2023
10 checks passed
@gastonfournier gastonfournier deleted the datadog-source-type-name branch July 10, 2023 13:38
gastonfournier added a commit that referenced this pull request Jul 12, 2023
@gastonfournier
chore: Datadog addon, ability to include source type name (#4196)
b0c0e35 
Include a new configuration parameter to be able to specify
source_type_name. This is an opt-in feature which provides backward
compatibility to our existing users.

![image](https://github.com/Unleash/unleash/assets/455064/0e65584f-f601-4f17-b7a5-e73dae55772e)

Closes #4109

Maybe this should be hardcoded to `Unleash` but this gives additional
flexibility
@gastonfournier gastonfournier mentioned this pull request Jul 12, 2023
Merged
gastonfournier added a commit that referenced this pull request Jul 12, 2023
@gastonfournier
chore: prepare 5.2 patch (#4224)
1bed7fc 
## About the changes
Early release of #4139 and
#4196 as 5.2 patch

---------

Co-authored-by: Christopher Kolstad <chriswk@getunleash.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk chriswk approved these changes

Assignees

@gastonfournier gastonfournier

Labels
improvement
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add source_type_name field in Datadog addon payload
2 participants
@gastonfournier @chriswk