Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strategy variant test UI #4199

Merged
merged 5 commits into from
Jul 11, 2023
Merged

feat: strategy variant test UI #4199

merged 5 commits into from
Jul 11, 2023

Conversation

kwasniew
Copy link
Contributor

About the changes

Strategy variant basic UI - will change but wanted to test it in sandbox for now. It's behind a feature flag.
Screenshot 2023-07-10 at 15 54 43

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jul 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2023 7:08am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 11, 2023 7:08am

src/lib/types/experimental.ts Outdated Show resolved Hide resolved
<ConditionallyRender
condition={Boolean(uiConfig?.flags?.strategyVariant)}
show={
<>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now, probably should be a separate component later on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary and design will change. Just wanted to demo this POC

@kwasniew kwasniew merged commit 5c4f15e into main Jul 11, 2023
17 checks passed
@kwasniew kwasniew deleted the strategy-variant-UI branch July 11, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants