fix: feature OpenAPI endpoints - project related #4212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
There's a lot of great work in here! 💯 Most of my comments are small suggestion and can be left at your own discretion, but I'd like to explore especially the thing about making the variant weight type into an enum. I'm afraid that could backfire or cause a breaking change. Of course, we could discuss whether that's a bug on the end user's part or not, but I'd like to hear your thoughts.
Also noticed that the endpoint responses in one of the files were missing some error codes, so I've added notes about that.
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
thomasheartman
approved these changes
Jul 14, 2023
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OpenAPI for
/api/admin/projects/{projectId}/features/and related endpoints