#4205: mark potentially stale features #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The migration adds a new `potentially_stale` column to the features table and sets this to true for any toggles that have exceeded their expected lifetime and that have not already been marked as `stale`.
thomasheartman
force-pushed
the
#4205/potentially-stale-events-db-migration
branch
from
1973498
to
85704e5
Compare
sjaanus
reviewed
Jul 12, 2023
thomasheartman
changed the title
sjaanus
reviewed
Jul 12, 2023
sjaanus
reviewed
Jul 12, 2023
sjaanus
reviewed
Jul 12, 2023
sjaanus
reviewed
Jul 12, 2023
sjaanus
reviewed
Jul 12, 2023
sjaanus
reviewed
Jul 12, 2023
sjaanus
reviewed
Jul 13, 2023
| currentTime?: string, | ||
| ): Promise<string[]> { | ||
| const query = this.db(TABLE) | ||
| .update('potentially_stale', true) |
There was a problem hiding this comment.
Should we also unmark them if configuration changes?
There was a problem hiding this comment.
That should be handled in the update method, I think. Do you disagree?
sjaanus
reviewed
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays most of the groundwork required for emitting events when features are marked as potentially stale by Unleash. It does not emit any events just yet. The summary is:
It is currently about 220 lines of tests and about 100 lines of application code (primarily db migration and two new methods on the IFeatureToggleStore interface).
The reason I wanted to put this into a single PR (instead of just the db migration, then just the potentially stale marking, then the update logic) is:
If users get the db migration first, but not the rest of the update logic until the events are fired, then they could get a bunch of new events for features that should have been marked as potentially stale several days/weeks/months ago. That seemed undesirable to me, so I decided to bunch those changes together. Of course, I'd be happy to break it into smaller parts.
Rules
A toggle will be marked as potentially stale iff:
Migration
The migration adds a new
potentially_stalecolumn to the featurestable and sets this to true for any toggles that have exceeded their
expected lifetime and that have not already been marked as
stale.Discussion
The
currentTimeparameter ofmarkPotentiallyStaleFeaturesThe
markPotentiallyStaleFetauresmethod takes an optionalcurrentTimeparameter. This was added to make it easier to test (so you can test "into the future"), but it's not used in the application. We can rewrite the tests to instead update feature toggles manually, but that wouldn't test the actual marking method. Happy to discuss.