Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: min items was breaking import #4219

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix: min items was breaking import #4219

merged 1 commit into from
Jul 11, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jul 11, 2023

About the changes

Prior to introducing minItems constraint some toggles were created that break this constraint. When we do batch import we get an error from schema validation.

minItems values constraint was introduced to prevent invalid constraints creation in a single item mode. When we do batch import mode it difficult to clean up all the items.

Important files

Discussion points

@vercel
Copy link

vercel bot commented Jul 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 11, 2023 10:29am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jul 11, 2023 10:29am

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change if it's necessary to not break things 💁🏼

@kwasniew kwasniew merged commit 81c0050 into main Jul 11, 2023
12 checks passed
@kwasniew kwasniew deleted the fix-import-schema branch July 11, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants