-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: project feature limit UI #4220
Conversation
sjaanus
commented
Jul 11, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking approve
@@ -126,6 +126,8 @@ const EditProject = () => { | |||
projectStickiness={projectStickiness} | |||
setProjectStickiness={setProjectStickiness} | |||
setProjectMode={setProjectMode} | |||
setFeatureLimit={() => {}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be defined?
@@ -126,6 +126,8 @@ const EditProject = () => { | |||
projectStickiness={projectStickiness} | |||
setProjectStickiness={setProjectStickiness} | |||
setProjectMode={setProjectMode} | |||
setFeatureLimit={() => {}} | |||
featureLimit={''} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this an empty string? Do you want to reset it on edit project?