feat: feature creation limit crud together with frontend #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjaanus
commented
Jul 12, 2023
•
sjaanus
commented
- Add saving and reading limit to backend with migration
- Remove old project settings methods
- UI to disable creation on frontend
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sjaanus
commented
Jul 12, 2023
src/lib/error/from-legacy-error.ts
Outdated
| @@ -21,14 +21,14 @@ const getStatusCode = (errorName: string): number => { | |||
| return 400; | |||
| case 'MinimumOneEnvironmentError': | |||
| return 400; | |||
| case 'InvalidOperationError': | |||
| return 400; | |||
There was a problem hiding this comment.
InvalidOperation should not be related to authorization, so not 403, but rather 400
There was a problem hiding this comment.
We use it for features behind a feature flag. We had a discussion about it and agreed on 403. Since it's forbidden behind a feature flag. I wouldn't change this one.
sjaanus
commented
Jul 12, 2023
| @@ -486,24 +505,6 @@ class ProjectStore implements IProjectStore { | |||
| return Number(members.count); | |||
| } | |||
|
|
|||
| async getProjectSettings(projectId: string): Promise<IProjectSettings> { | |||
There was a problem hiding this comment.
Cleaning up leftover code
kwasniew
reviewed
Jul 12, 2023
kwasniew
reviewed
Jul 12, 2023
kwasniew
reviewed
Jul 12, 2023
kwasniew
reviewed
Jul 12, 2023
kwasniew
reviewed
Jul 12, 2023
kwasniew
reviewed
Jul 12, 2023
kwasniew
reviewed
Jul 12, 2023
kwasniew
requested changes
Jul 12, 2023
kwasniew
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.