feat: strategy variant migrations #4225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
kwasniew
commented
Jul 13, 2023
| exports.up = function (db, callback) { | ||
| db.runSql( | ||
| ` | ||
| ALTER TABLE feature_strategies ADD COLUMN IF NOT EXISTS variants JSONB DEFAULT '[]'::jsonb NOT NULL; |
kwasniew
commented
Jul 13, 2023
| fss.segment_id as segments, | ||
| feature_strategies.title as strategy_title, | ||
| feature_strategies.disabled as strategy_disabled, | ||
| feature_strategies.variants as strategy_variants |
There was a problem hiding this comment.
this is the only new line compared to the previous view
kwasniew
commented
Jul 13, 2023
| feature_strategies.sort_order as sort_order, | ||
| fss.segment_id as segments, | ||
| feature_strategies.title as strategy_title, | ||
| feature_strategies.disabled as strategy_disabled |
There was a problem hiding this comment.
this is the only new line compared to the previous rollback code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Adding variants JSONB column to strategies that will allow subsequent PRs introduce support for the strategy variants.
It's less than 10 LOC, most of the code is the old view definition with a new line added.
More comments inline.
Important files
Discussion points