feat: strategy variant schema openapi #4232
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
This is very nice! 💯 I've got a few minor suggestions but no real blockers. What's interesting here, though, is how we add this to the schema. I know you added the [WIP] annotation at the start of every description for these schemas. I don't think there is an unstable property for schemas, so it might be the best we have for now. But maybe we could make it more explicit in case you don't understand what WIP means. Maybe something like: This is an experimental property. It may change or be removed as we work on it. Please don't depend on it yet. or something like that? What do you think?
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
About the changes
Introducing a new openapi concept for the strategy variant. It differs from the old variant in two ways:
I don't know why weightType and stickiness were not required for the old variants but it makes types align with the application services (tested in a separate POC).
Added WIP in description so that people don't have expectations that it's already implemented.
Create and read variant differ by additionalProperties requirement.
Important files
Discussion points