Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist strategy variants #4236

Merged
merged 7 commits into from
Jul 13, 2023
Merged

Persist strategy variants #4236

merged 7 commits into from
Jul 13, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jul 13, 2023

About the changes

Strategy variants can be creates/update/read. When variants are present they are validates with joi and weights are re-calculated as for the old variants.

The test documents how it all works.

Important files

Discussion points

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 13, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@vercel
Copy link

vercel bot commented Jul 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 13, 2023 1:17pm
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Jul 13, 2023 1:17pm

Copy link
Contributor

@andreas-unleash andreas-unleash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking approve - looks good

@kwasniew kwasniew merged commit 87b46ea into main Jul 13, 2023
10 checks passed
@kwasniew kwasniew deleted the persist-strategy-variants branch July 13, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants