-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client api with proper client segments and strategy variants #4244
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
id: row.strategy_id, | ||
name: row.strategy_name, | ||
title: row.strategy_title, | ||
constraints: row.constraints || [], | ||
parameters: mapValues(row.parameters || {}, ensureStringValue), | ||
sortOrder: row.sort_order, | ||
}; | ||
if (this.flagResolver.isEnabled('strategyVariant')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can selectively enable it to test different SDKs
this.db = db; | ||
this.logger = getLogger('feature-toggle-client-store.ts'); | ||
this.timer = (action) => | ||
metricsHelper.wrapTimer(eventBus, DB_TIME, { | ||
store: 'feature-toggle', | ||
action, | ||
}); | ||
this.flagResolver = flagResolver; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to control strategy variants at the store query level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
About the changes
Important files
Discussion points