feat: strategy variant UI spike #4246
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -246,6 +247,16 @@ export const FeatureStrategyForm = ({ | |||
| hasAccess={access} | |||
| /> | |||
| <StyledHr /> | |||
| <ConditionallyRender | |||
There was a problem hiding this comment.
every old strategy will get a variant support
| @@ -126,34 +123,6 @@ const FlexibleStrategy = ({ | |||
| onChange={e => onUpdate('groupId')(e.target.value)} | |||
| data-testid={FLEXIBLE_STRATEGY_GROUP_ID} | |||
| /> | |||
| <ConditionallyRender | |||
There was a problem hiding this comment.
previously on gradual rollout had basic variant support
| @@ -0,0 +1,129 @@ | |||
| import { | |||
There was a problem hiding this comment.
This entire file is taken from POC and will be rewritten from scratch so no need to review as it's hidden behind a flag. This is to allow testing in sandbox.
| @@ -150,7 +150,6 @@ interface IVariantFormProps { | |||
| variants: IFeatureVariantEdit[]; | |||
| updateVariant: (updatedVariant: IFeatureVariantEdit) => void; | |||
| removeVariant: (variantId: string) => void; | |||
| projectId: string; | |||
There was a problem hiding this comment.
prop unused inside the component
About the changes
Spike for the strategy variants
The main file will be reworked from scratch and tests with unit tests. I'm adding it for demoing purposes behind a flag.
Important files
Discussion points