feat: Change Request on Reorder UI #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
…ents Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
kwasniew
requested changes
Jul 19, 2023
| @@ -8,7 +8,8 @@ export interface IChangeSchema { | |||
| | 'addStrategy' | |||
| | 'updateStrategy' | |||
| | 'deleteStrategy' | |||
| | 'patchVariant'; | |||
| | 'patchVariant' | |||
| | 'updateEnvironmentStrategyExecutionOrder'; | |||
There was a problem hiding this comment.
I think it's reorderStrategy in the backend schema
kwasniew
reviewed
Jul 19, 2023
| @@ -9,6 +9,9 @@ import { IFeatureEnvironment } from 'interfaces/featureToggle'; | |||
| import { FeatureStrategyEmpty } from 'component/feature/FeatureStrategy/FeatureStrategyEmpty/FeatureStrategyEmpty'; | |||
| import { useRequiredPathParam } from 'hooks/useRequiredPathParam'; | |||
| import { useFeature } from 'hooks/api/getters/useFeature/useFeature'; | |||
| import { useChangeRequestApi } from '../../../../../../../hooks/api/actions/useChangeRequestApi/useChangeRequestApi'; | |||
| import { useChangeRequestsEnabled } from '../../../../../../../hooks/useChangeRequestsEnabled'; | |||
| import { usePendingChangeRequests } from '../../../../../../../hooks/api/getters/usePendingChangeRequests/usePendingChangeRequests'; | |||
kwasniew
reviewed
Jul 19, 2023
| ); | ||
| const environmentStrategies = featureEnvironment?.strategies || []; | ||
|
|
||
| const preData = { |
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Dots in the weird place. Also the UI is not very informative. Maybe we should have strategy name in the UI
|
kwasniew
approved these changes
Jul 20, 2023
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
andreas-unleash
deleted the
feat/feature_envrionment_strategy_execution_FE
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change request UI for reordering strategies with variants
About the changes
Closes #
Important files
Discussion points