Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy variants stickiness #4250

Merged
merged 7 commits into from
Jul 17, 2023
Merged

Strategy variants stickiness #4250

merged 7 commits into from
Jul 17, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jul 17, 2023

About the changes

Screenshot 2023-07-17 at 11 21 42
  • Passing stickiness from the strategy to the variants so that they are always in sync for the strategy variants
  • IFeatureStrategyVariant removed and back to IFeatureVariant with optional overrides. It is less invasive in the existing code
  • Ability to disableOverrides in VariantForm since the new strategy variants don't need to override anythings (they have access to constraints and segments as first class citizens)
  • stickiness param presence enables strategy variants support so any strategy that has it will automatically get variants

Important files

Discussion points

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 17, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 11:53am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 17, 2023 11:53am

@kwasniew kwasniew merged commit 56d5579 into main Jul 17, 2023
12 of 15 checks passed
@kwasniew kwasniew deleted the strategy-variants-stickiness branch July 17, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants