#4205: add openapi definition for the new endpoint #4256

thomasheartman · 2023-07-17T13:55:45Z

This PR adds an operation and accompanying openapi docs for the new "update feature type lifetime" API operation.

It also fixes an oversight where the other endpoint on the same controller didn't use respondWithValidation.

Note: the API here is a suggestion. I'd like to hear whether you agree with this implementation or not.

sonatype-lift · 2023-07-17T13:55:49Z

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

vercel · 2023-07-17T13:55:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
unleash-monorepo-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2023 8:50am

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
unleash-docs	⬜️ Ignored (Inspect)			Jul 18, 2023 8:50am

This is what we already use everywhere else, so it's better to stay consistent here.

src/lib/routes/admin-api/feature-type.ts

This PR updates the feature type service by adding a new `updateLifetime` method. This method handles the connection between the API (#4256) and the store (#4252). I've also added some new e2e tests to ensure that the API behaves as expected.

thomasheartman added 2 commits July 17, 2023 15:45

Wip: impl

e435218

openapi: respond with validation for old endpoint

40af287

github-actions bot assigned thomasheartman Jul 17, 2023

feat(#4205): add openapi definition for the new endpoint

6f6326e

thomasheartman force-pushed the feat(#4205)/update-lifetime-api branch from c49836f to 6f6326e Compare July 17, 2023 13:56

thomasheartman added 3 commits July 17, 2023 15:58

Chore: fix typo in schema

ea80ae4

Fix: example value type

4033d4b

Chore: use lifetimeDays in request schema to stay consistent

9082761

This is what we already use everywhere else, so it's better to stay consistent here.

vercel bot deployed to Preview – unleash-monorepo-frontend July 18, 2023 08:13 View deployment

Chore: update descriptions to indicate that null and 0 are the same

af97f82

vercel bot deployed to Preview – unleash-monorepo-frontend July 18, 2023 08:33 View deployment

thomasheartman mentioned this pull request Jul 18, 2023

feat(#4205): implement configurable lifetimes #4263

Merged

Tymek approved these changes Jul 18, 2023

View reviewed changes

src/lib/routes/admin-api/feature-type.ts Show resolved Hide resolved

Chore: add 409 as response

a0c2c55

thomasheartman enabled auto-merge (squash) July 18, 2023 08:49

vercel bot deployed to Preview – unleash-monorepo-frontend July 18, 2023 08:50 View deployment

thomasheartman merged commit 34aeca2 into main Jul 18, 2023
16 checks passed

thomasheartman deleted the feat(#4205)/update-lifetime-api branch July 18, 2023 09:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#4205: add openapi definition for the new endpoint #4256

#4205: add openapi definition for the new endpoint #4256

thomasheartman commented Jul 17, 2023

sonatype-lift bot commented Jul 17, 2023

vercel bot commented Jul 17, 2023 •

edited

#4205: add openapi definition for the new endpoint #4256

#4205: add openapi definition for the new endpoint #4256

Conversation

thomasheartman commented Jul 17, 2023

sonatype-lift bot commented Jul 17, 2023

Sonatype Lift is retiring

vercel bot commented Jul 17, 2023 • edited

vercel bot commented Jul 17, 2023 •

edited