Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Feature toggle type - edit form #4269

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Jul 18, 2023

About the changes

image

Task: https://linear.app/unleash/issue/1-1127/add-front-end

Important files

frontend/src/component/featureTypes/FeatureTypeForm/FeatureTypeForm.tsx

Discussion points

FIXME will be addressed when integrating with API

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 18, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 3:39pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 3:39pm

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it behind a flag?

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocking approve but please add RTL test

@Tymek
Copy link
Member Author

Tymek commented Jul 20, 2023

Is it behind a flag?

Correct. Flag in routes file

@Tymek Tymek merged commit d370829 into main Jul 20, 2023
16 checks passed
@Tymek Tymek deleted the feat/feature-toggle-type-edit branch July 20, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants