Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Edge updates for docs/proxy-hosting #4275

Merged
merged 12 commits into from
Aug 2, 2023
Merged

Conversation

markunl
Copy link
Contributor

@markunl markunl commented Jul 18, 2023

About the changes

Edge updates for docs/proxy-hosting: https://docs.getunleash.io/topics/proxy-hosting
Edge is the recommended replacement for the proxy. Existing proxy content has been preserved for reference as the proxy is still supported and customers are using it.

Closes #

Important files

website/topics/proxy-hosting.mdx

Discussion points

General review for accuracy

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 5:53pm
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 1, 2023 5:53pm

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 18, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

Copy link
Contributor

@sebastian-bury sebastian-bury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add in a note about Edge being able to accept dynamic tokens and allow for new tokens to be passed to it that it didn't know about before, this is a big addition and makes it much easier to scale up additional applications and things that use new tokens without having to restart proxy or make large changes to infra

lines 40-43, probably in there?

@markunl
Copy link
Contributor Author

markunl commented Jul 21, 2023

I would add in a note about Edge being able to accept dynamic tokens and allow for new tokens to be passed to it that it didn't know about before, this is a big addition and makes it much easier to scale up additional applications and things that use new tokens without having to restart proxy or make large changes to infra

lines 40-43, probably in there?

Thanks for the feedback, added to line 41:

  • A key benefit of Edge is its ability to dynamically update new tokens while running. This greatly simplifies scaling up additional application workloads that leverage new tokens without the need to restart the instance or make large changes to infra, as was the prior requirement with the proxy.

@markunl markunl closed this Jul 21, 2023
@markunl markunl reopened this Jul 21, 2023
Copy link
Contributor Author

@markunl markunl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback!

Added to line 41:

  • A key benefit of Edge is its ability to dynamically update new tokens while running. This greatly simplifies scaling up additional application workloads that leverage new tokens without the need to restart the instance or make large changes to infra, as was the prior requirement with the proxy.

@sebastian-bury sebastian-bury self-requested a review July 21, 2023 14:32
Copy link
Contributor

@sebastian-bury sebastian-bury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@sebastian-bury sebastian-bury enabled auto-merge (squash) July 21, 2023 15:05
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind looking over some of the feedback I've left here before we merge? Happy to not implement it, but I think there are some important details here

website/docs/topics/proxy-hosting.mdx Outdated Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Outdated Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Outdated Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Outdated Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Outdated Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Outdated Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Outdated Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Outdated Show resolved Hide resolved
website/docs/topics/proxy-hosting.mdx Show resolved Hide resolved
Co-authored-by: Simon Hornby <liquidwicked64@gmail.com>
Copy link
Contributor Author

@markunl markunl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sighphyre for the in depth review. Great feedback that improves the accuracy and quality of the document. All suggestions should now be incorporated in the latest commit

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this one!

@sighphyre sighphyre disabled auto-merge August 2, 2023 12:31
@sighphyre sighphyre merged commit 187ed8a into main Aug 2, 2023
14 checks passed
@sighphyre sighphyre deleted the docs/proxy-hosting-edge branch August 2, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants