-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Edge updates for docs/proxy-hosting #4275
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add in a note about Edge being able to accept dynamic tokens and allow for new tokens to be passed to it that it didn't know about before, this is a big addition and makes it much easier to scale up additional applications and things that use new tokens without having to restart proxy or make large changes to infra
lines 40-43, probably in there?
Thanks for the feedback, added to line 41:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback!
Added to line 41:
- A key benefit of Edge is its ability to dynamically update new tokens while running. This greatly simplifies scaling up additional application workloads that leverage new tokens without the need to restart the instance or make large changes to infra, as was the prior requirement with the proxy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind looking over some of the feedback I've left here before we merge? Happy to not implement it, but I think there are some important details here
Co-authored-by: Simon Hornby <liquidwicked64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sighphyre for the in depth review. Great feedback that improves the accuracy and quality of the document. All suggestions should now be incorporated in the latest commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this one!
About the changes
Edge updates for docs/proxy-hosting: https://docs.getunleash.io/topics/proxy-hosting
Edge is the recommended replacement for the proxy. Existing proxy content has been preserved for reference as the proxy is still supported and customers are using it.
Closes #
Important files
website/topics/proxy-hosting.mdx
Discussion points
General review for accuracy