fix: missing events in the event store

[gastonfournier]

About the changes

We are losing some events because of not having "created by" which is required by a constraint in the DB. One scenario where this can happen is with the default user admin, because it doesn't have a username or an email (unless configured by the administrator).

Our code makes assumptions on the existence of one of these 2 attributes (e.g.

unleash/src/lib/services/user-service.ts

Lines 220 to 222 in 248118a

	private getCreatedBy(updatedBy: User = systemUser) {
	return updatedBy.username || updatedBy.email;
	}

).

Event lost metrics:

Discussion points

The solution proposed here is falling back to a default value. I've chosen "admin" because it covers one of the use cases, but it can also be "system" mimicking

unleash/src/lib/services/user-service.ts

Line 32 in 248118a

const systemUser = new User({ id: -1, username: 'system' });

which is used as a default, or "unknown" which is sometimes used as a default:

unleash/src/lib/services/project-service.ts

Line 57 in 248118a

const getCreatedBy = (user: IUser) => user.email || user.username || 'unknown';

Anyway, I believe it's better not to lose the event rather than be accurate with the "created by" that can be fixed later

[sonatype-lift]

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
unleash-docs	⬜️ Ignored (Inspect)		Jul 24, 2023 0:24am
unleash-monorepo-frontend	⬜️ Ignored (Inspect)		Jul 24, 2023 0:24am

[kwasniew]

good idea