fix: sync enabled and variant status #4345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Jul 26, 2023
| @@ -176,7 +176,11 @@ export class PlaygroundService { | |||
| data: strategyEvaluationResult.strategies, | |||
| }, | |||
| projectId: featureProject[feature.name], | |||
| variant: client.getVariant(feature.name, clientContext), | |||
| variant: client.forceGetVariant( | |||
There was a problem hiding this comment.
we're forcing variant to the strategy evaluation result
kwasniew
commented
Jul 26, 2023
| @@ -104,13 +104,18 @@ export class FeatureEvaluator { | |||
|
|
|||
| forceGetVariant( | |||
| name: string, | |||
| forcedResults: Pick< | |||
There was a problem hiding this comment.
explicit value to force it to
Tymek
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When we have non 100% gradual rollout with random stickiness enabled status and variant value were getting out of sync. This was because variant is checking isEnabled under the hood. In the new version we also verify isEnabled result (than contains enabled strategy variant). The new force version accepts the explicit evaluation result instead of a boolean flag.
Important files
Discussion points