Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stable bulk updates #4352

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: stable bulk updates #4352

merged 1 commit into from
Jul 28, 2023

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Jul 27, 2023

About the changes

Prevent re-fetched state change from de-selecting rows.

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 27, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@vercel
Copy link

vercel bot commented Jul 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 11:10am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 27, 2023 11:10am

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a sensible change to me! Are there any cases where this'll cause your selected rows to change (might happen if it was based on list ordering, for instance)? I'm guessing it's based on some sort of identifier to prevent that?

@Tymek Tymek merged commit fc54877 into main Jul 28, 2023
17 checks passed
@Tymek Tymek deleted the fix/table-select-unstable branch July 28, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants