Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: strategy variants alert #4371

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Jul 31, 2023

About the changes

Static strategy variants SDK upgrade alert.
Screenshot 2023-07-31 at 12 08 34

Important files

Discussion points

I'm thinking whether we should do SDK version detection in the backend and return this warning conditionally.

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 31, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 10:08am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jul 31, 2023 10:08am

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change! Regarding SDK detection: we could do that, but what if they haven't used any SDKs yet? In that case it's likely that they'll use the most recent versions of the SDKs, but maybe not 🤷🏼 I think it's safer to do it this way, but I really like the idea 😄

@kwasniew
Copy link
Contributor Author

@thomasheartman I'd say building infrastructure for SDK detection is a bigger initiative that can span beyond this feature. Let's see if the static box will suffice for now :)

@kwasniew kwasniew merged commit b34f00c into main Jul 31, 2023
17 checks passed
@kwasniew kwasniew deleted the strategy-variants-version-alert branch July 31, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants