fix: EventStore#getMaxRevisionId can return null

[acr92]

In a new fresh Unleash instance with cache enabled this can cause feature toggles to never get updated.

We saw in our client that the ETag was ETag: "60e35fba:null" Which looked incorrect for us.

I also did manual testing and if the andWhere had a value of largerThan higher than whatever the id was then we would get back { max: null }.

This should fix that issue.

[sonatype-lift]

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
unleash-monorepo-frontend	⬜️ Ignored (Inspect)	Visit Preview		Aug 1, 2023 8:35pm

[vercel]

@acr92 is attempting to deploy a commit to the unleash-team Team on Vercel.

A member of the Team first needs to authorize it.

[ivarconr]

A bit surprised the tests are failing.

[SimenB]

A bit surprised the tests are failing.

unleash/src/lib/features/feature-toggle/configuration-revision-service.ts

Lines 23 to 29 in 6c5df9f

	async getMaxRevisionId(): Promise<number> {
	if (this.revisionId) {
	return this.revisionId;
	} else {
	return this.updateMaxRevisionId();
	}
	}

hits else now, so maybe whatever sets it to 16 is never called?

The changes insrc/lib/features/feature-toggle/configuration-revision-service.ts aren't needed (even though they're more correct), but maybe it should be set to 0? Or just left alone even though the number type should then be number | undefined