Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Password hash is null should yield PasswordMissmatch #4392

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

ivarconr
Copy link
Member

@ivarconr ivarconr commented Aug 2, 2023

We are giving a strange error message if the user does not have a password_hash defined in the database.

@ivarconr ivarconr requested a review from kwasniew August 2, 2023 17:59
@sonatype-lift
Copy link

sonatype-lift bot commented Aug 2, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@vercel
Copy link

vercel bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2023 6:10pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2023 6:10pm

@@ -34,6 +34,7 @@ class IndexRouter extends Controller {
max: 10,
standardHeaders: true,
legacyHeaders: false,
validate: false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, this was a mistake.

src/lib/routes/index.ts Outdated Show resolved Hide resolved
@ivarconr ivarconr merged commit 5377243 into main Aug 3, 2023
11 checks passed
@ivarconr ivarconr deleted the fix/password_hash_is_null branch August 3, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants