feat: optional change request feature #4394
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
| exports.down = function (db, callback) { | ||
| db.runSql( | ||
| ` | ||
| UPDATE change_request_events SET feature = 'unknown' WHERE feature IS NULL; |
There was a problem hiding this comment.
This will not work, because it is invalid foreign key.
There was a problem hiding this comment.
good point, what options do we have? delete those?
There was a problem hiding this comment.
Yeah, not ideal, but acceptable.
There was a problem hiding this comment.
FYI, there is no ideal solution. We kind of want to retain all user data, but it will be super hard anyways, if they do down migrations.
|
@thomasheartman I have a PR coming soon that uses this migration and allows to perform full segment update workflow through change request. It will have a corresponding test showing how to use it. |
About the changes
In change request changes we had required feature name. Now we introduce segment changes that don't have any single feature attached. So I'm making the feature column optional. Segment id will be part of the payload same as strategy id is. In the long term we may even consider adding feature name to the payload.
Important files
Discussion points