Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow trust proxy #4396

Merged
merged 1 commit into from
Aug 3, 2023
Merged

feat: allow trust proxy #4396

merged 1 commit into from
Aug 3, 2023

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Aug 3, 2023

We have configured the trust proxy setting to true. With this configuration, the application places trust in the "X-Forwarded-For" header and considers the left-most entry in the header as the client's IP address. By doing so, the application relies on the proxy or load balancer to accurately set the "X-Forwarded-For" header with the correct client IP address.

However, it is important to be aware that this configuration also opens up the possibility of bypassing IP-based rate limiting. The rate-limiter system is currently logging this situation as a warning to alert us.

With this PR we are suppressing the warning.

@sonatype-lift
Copy link

sonatype-lift bot commented Aug 3, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@vercel
Copy link

vercel bot commented Aug 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Aug 3, 2023 9:38am
1 Ignored Deployment
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Aug 3, 2023 9:38am

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! But just for clarity: the only difference this makes is that we'll no longer log the warning. The behavior is still the same as before?

@sjaanus
Copy link
Contributor Author

sjaanus commented Aug 3, 2023

Looks good to me! But just for clarity: the only difference this makes is that we'll no longer log the warning. The behavior is still the same as before?

Yes, behaviour is still same.

@sjaanus sjaanus merged commit f140b02 into main Aug 3, 2023
14 of 18 checks passed
@sjaanus sjaanus deleted the allow-trust-proxy branch August 3, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants