feat: segments in pending CR screen #4420
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -18,6 +20,30 @@ export const ChangeRequest: VFC<IChangeRequestProps> = ({ | |||
| }) => { | |||
| return ( | |||
| <Box> | |||
| <ConditionallyRender | |||
There was a problem hiding this comment.
I'm thinking whether segment of features should go first
| overflow: 'hidden', | ||
| })} | ||
| > | ||
| <Box |
There was a problem hiding this comment.
With more than 1-2 sx values I usually extract a component
| defaultChange?: IChangeRequestAddStrategy | IChangeRequestEnabled; | ||
| } | ||
|
|
||
| export interface IChangeRequestSegment { |
There was a problem hiding this comment.
We could try using orval generated types in the next PR
| @@ -44,7 +52,7 @@ export interface IChangeRequestComment { | |||
| id: string; | |||
| } | |||
|
|
|||
| export interface IChangeRequestBase { | |||
| export interface IChangeRequestChangeBase { | |||
There was a problem hiding this comment.
I'm thinking about creating a separate ticket for using generated types for those so that we have e2e type safety
This is the first iteration of segments in pending CR screen.
Still need to add bunch of things, but those will be separate PR.