fix: deletion validation didnt account for groups #4441
Conversation
Sonatype Lift is retiringSonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/lib/services/access-service.ts
Outdated
| throw new RoleInUseError( | ||
| 'Role is in use by more than one user. You cannot delete a role that is in use without first removing the role from the users.', | ||
| 'Role is in use by one or more users or groups. You cannot delete a role that is in use without first removing the role from the users and groups.', |
There was a problem hiding this comment.
two ifs here and different error messages would probably make this easier to debug for the user
There was a problem hiding this comment.
Or just a simple users(0) or groups(23)
There was a problem hiding this comment.
Thanks @gardleopard! good feedback! I like the simple solution as it gives you overview of both regardless of which was the trigger. This is also part of an improvement of the UI that gives you an overview of usage before you attempt deleting
About the changes
Fixes an issue where project role deletion validation didn't validate against project roles being connected to groups