fix: CR strategy name changes code #4449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses two things that were done in #4004 and that I believe to be bugs. 1. It shows the previous strategy name also if there was no previous title. So if there was no previous title, it'll show the strategy name with a strikethrough and then the new title. 2. It changes a `span` component to a `del` component. I believe the span was erroneously changed from a `s` component (strikethrough component) in the linked PR (based on a comment on the PR). This caused the strikethrough to not be there anymore. However, the `del` component is semantically more correct and reintroduces the strikethrough, so it is a better change. Finally, it removes a redundant pair of curly braces.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kwasniew
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
I like the last option you suggested with ins the most.
Since we have lots of "if this then that" dilemmas and this code is at the core of Unleash I'd add a unit test for the tooltip describing the 3 cases you put as screenshots. I know it takes more time to finish the work but in this case it seems to be justified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses two things that were done in
#4004 and that I believe to be bugs.
title. So if there was no previous title, it'll show the strategy name
with a strikethrough and then the new title (see the discussion section).
spancomponent to adelcomponent. I believe thespan was erroneously changed from a
scomponent (strikethroughcomponent) in the linked PR (based on a comment on the PR). This
caused the strikethrough to not be there anymore. However, the
delcomponent is semantically more correct and reintroduces the
strikethrough, so it is a better change.
inselements for names that have changed.Finally, it removes a redundant pair of curly braces.
How it looks now:
Discussion
Regarding point 1: It might be that we don't want to show a strikethrough through the name of the strategy if there was no previous title. In that case, the changes related to the first point should be removed. If we do that, it looks like this:
It makes it harder (impossible, actually) to see when a custom title was added, but that might be what we want.
But maybe the solution is to also use
inselements for new data. That way the difference is visible (and semantically correct):