Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements for demo and docs update #4454

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented Aug 9, 2023

About the changes

Sorry for adding 2 changes together:

  • renamed feature strategy variants to strategy variants based on feedback from Mark
  • improved performance of our demo step by not loading all 200+ strategies when not needed

Important files

Discussion points

@vercel
Copy link

vercel bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 10:52am
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2023 10:52am

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwasniew kwasniew merged commit c549280 into main Aug 9, 2023
13 of 16 checks passed
@kwasniew kwasniew deleted the performance-improvements-demo-pt2 branch August 9, 2023 10:58
nunogois added a commit that referenced this pull request Aug 10, 2023
This should fix `import` and `access` Cypress e2e tests after recent
changes were introduced:

- `import.spec.ts` - Expected '50%' to be contained in the page, however
now [we are lazy loading the accordion
content](#4454);
- `access.spec.ts` - Expected 'within a project are allowed' to be
visible as a role description, however [we updated the predefined roles
descriptions](#4451);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants