Demo for strategy variants #4457
Conversation
…or-old-variants
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Haven't tested it but at a glance this looks good 👍
I suggest going through the flow manually and also try to go back in some of the steps to see if it doesn't break.
Aligning with UX would also be a good idea just to be extra safe that this is what we intend.
| ]), | ||
| } | ||
| const tooGenericStrategies = results.filter( | ||
| (strategy: { constraints: Array<unknown>; segments: Array<unknown> }) => |
There was a problem hiding this comment.
Don't we have the proper types for this instead of unknown?
There was a problem hiding this comment.
we don't care about those types so I left it as unknown. We care about the array length
| }, | ||
| }, | ||
| ]), | ||
| } |
There was a problem hiding this comment.
This means we no longer have one of red, green, blue on the demo app on a clean slate, right? Will it default to black? I honestly don't remember.
I'm OK with it, but it's something we should be aware of and maybe align with @EliseBrevald and @nicolaesocaciu
There was a problem hiding this comment.
I didn't know the context of those so glad your brought it up. I can bring those back as fallback. It shouldn't change much for the strategy variants.
About the changes
Screen.Recording.2023-08-09.at.15.12.45.mov
Important files
Discussion points