fix: Disable Edit constraint when context field was deleted #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| const { contextName } = constraint; | ||
|
|
||
| const disableEdit = !context | ||
| .map(contextDefinition => contextDefinition.name) |
There was a problem hiding this comment.
Suggested change
| .map(contextDefinition => contextDefinition.name) | |
| .map(({name}) => name) |
Another concise way to do
kwasniew
approved these changes
Aug 10, 2023
| @@ -3,6 +3,7 @@ import { IConstraint } from 'interfaces/strategy'; | |||
| import { ConstraintAccordionViewHeaderInfo } from './ConstraintAccordionViewHeaderInfo'; | |||
| import { ConstraintAccordionHeaderActions } from '../../ConstraintAccordionHeaderActions/ConstraintAccordionHeaderActions'; | |||
| import { styled } from '@mui/system'; | |||
| import useUnleashContext from '../../../../../hooks/api/getters/useUnleashContext/useUnleashContext'; | |||
| @@ -34,6 +35,13 @@ export const ConstraintAccordionViewHeader = ({ | |||
| expanded, | |||
| compact, | |||
| }: IConstraintAccordionViewHeaderProps) => { | |||
| const { context } = useUnleashContext(); | |||
There was a problem hiding this comment.
we could create useContextFieldExists('name') hook
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
…ld_was_deleted # Conflicts: # frontend/cypress/integration/import/import.spec.ts
andreas-unleash
deleted the
fix/disable_edit_constraint_when_context_field_was_deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable Edit constraint when context field was deleted
Closes: 1-1208