Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add usage info to project role deletion dialog #4464

Merged
merged 18 commits into from
Aug 17, 2023

Conversation

daveleek
Copy link
Contributor

@daveleek daveleek commented Aug 10, 2023

About the changes

Adds projects user and group -usage information to the dialog shown when user wants to delete a project role

Skjermbilde 2023-08-10 kl  08 28 40

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 6:28am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Aug 17, 2023 6:28am

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but I think we can still do better, so I left a few comments.
Let me know if you need help tackling them 👍

daveleek and others added 2 commits August 11, 2023 13:20
…/RoleDeleteDialog.tsx

Co-authored-by: Nuno Góis <github@nunogois.com>
…/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoles.tsx

Co-authored-by: Nuno Góis <github@nunogois.com>
daveleek and others added 2 commits August 11, 2023 14:00
…/RoleDeleteDialogProjectRoles/RoleDeleteDialogProjectRoles.tsx

Co-authored-by: Nuno Góis <github@nunogois.com>
…/RoleDeleteDialogRootRoles/RoleDeleteDialogRootRoles.tsx

Co-authored-by: Nuno Góis <github@nunogois.com>
Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to go.

@daveleek daveleek merged commit 76d3cc5 into main Aug 17, 2023
16 checks passed
@daveleek daveleek deleted the feat/project-role-deletion-dialog-info branch August 17, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants