feat: delete segment from CR #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sjaanus
commented
Aug 10, 2023
| @@ -55,7 +63,7 @@ export const ChangeRequest: VFC<IChangeRequestProps> = ({ | |||
| {feature.changes.map((change, index) => ( | |||
| <FeatureChange | |||
| key={index} | |||
| discard={ | |||
| actions={ | |||
There was a problem hiding this comment.
Renaming old confusing prop name
sjaanus
commented
Aug 10, 2023
| @@ -60,7 +57,7 @@ const StyledPopover = styled(Popover)(({ theme }) => ({ | |||
| export const ChangeActions: FC<{ | |||
| changeRequest: IChangeRequest; | |||
| feature: string; | |||
| change: IFeatureChange; | |||
| change: IChange; | |||
There was a problem hiding this comment.
Now can take in all type of changes
kwasniew
reviewed
Aug 10, 2023
| actions={ | ||
| <ChangeActions | ||
| changeRequest={changeRequest} | ||
| feature={segmentChange.name} |
There was a problem hiding this comment.
Hmm. segmentChange.name is not a feature name, but a current segment name of the segment you're changing.
There was a problem hiding this comment.
Yes, currently ChangeActions has actions for delete and edit. Edit needs a name of something. Currently providing segment name, but when we implement edit of segment change, then we need to refactor this a little.
kwasniew
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.