Change request reject UI #4489
Merged
Change request reject UI #4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
…-request-reject-ui
kwasniew
commented
Aug 14, 2023
| @@ -161,25 +156,7 @@ export const ChangeRequestOverview: FC = () => { | |||
| <ChangeRequestBody> | |||
| <StyledAsideBox> | |||
| <ChangeRequestTimeline state={changeRequest.state} /> | |||
| <ChangeRequestReviewers | |||
There was a problem hiding this comment.
moved to a new component so that adding rejectors is easier
kwasniew
commented
Aug 14, 2023
| approvals: IChangeRequestApproval[]; | ||
| } | ||
|
|
||
| export const ChangeRequestApprovals: FC<ChangeRequestApprovalProps> = ({ |
There was a problem hiding this comment.
approvers extracted into a new components
kwasniew
commented
Aug 14, 2023
| rejections: IChangeRequestApproval[]; | ||
| } | ||
|
|
||
| export const ChangeRequestRejections: FC<ChangeRequestRejectionProps> = ({ |
There was a problem hiding this comment.
rejectors just added in this PR
kwasniew
commented
Aug 14, 2023
| > | ||
| {name} | ||
| </Typography> | ||
| <ReviewerName variant="body1">{name}</ReviewerName> |
There was a problem hiding this comment.
extracted styled component
kwasniew
commented
Aug 14, 2023
| condition={Boolean( | ||
| uiConfig?.flags?.changeRequestReject | ||
| )} | ||
| show={ |
There was a problem hiding this comment.
this will open a modal in the next PR. For now it makes a direct change to test it E2E
kwasniew
commented
Aug 14, 2023
| {children} | ||
| </Paper> | ||
| ); | ||
| }; | ||
|
|
||
| export const ChangeRequestReviewers: FC<{ |
There was a problem hiding this comment.
Existing code extracted here + added rejectors init
kwasniew
commented
Aug 14, 2023
| @@ -72,11 +72,13 @@ export const ChangeRequestsTabs = ({ | |||
| const open = changeRequests.filter( | |||
| changeRequest => | |||
| changeRequest.state !== 'Cancelled' && | |||
| changeRequest.state !== 'Rejected' && | |||
There was a problem hiding this comment.
rejections show on closed list
sjaanus
reviewed
Aug 14, 2023
| import { FC, useContext, useState } from 'react'; | ||
| import { Box } from '@mui/material'; | ||
| import { Alert, Box, Button, styled, Typography } from '@mui/material'; | ||
| import React, { FC, useContext, useState } from 'react'; |
sjaanus
reviewed
Aug 14, 2023
| @@ -0,0 +1,30 @@ | |||
| import React, { FC } from 'react'; | |||
| import { Typography } from '@mui/material'; | |||
| import { ConditionallyRender } from '../../../common/ConditionallyRender/ConditionallyRender'; | |||
sjaanus
approved these changes
Aug 14, 2023
|
Not blocking approval, minor comments. |
chriswk
pushed a commit
that referenced
this pull request
Aug 21, 2023
chriswk
pushed a commit
that referenced
this pull request
Aug 21, 2023
nunogois
pushed a commit
that referenced
this pull request
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Important files
Discussion points