Task/multiple roles groups #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
chriswk
force-pushed
the
task/multipleRolesGroups
branch
from
b10ef43
to
e0921c7
Compare
chriswk
force-pushed
the
task/multipleRolesGroups
branch
from
cc1559f
to
fa2ed10
Compare
nunogois
reviewed
Aug 22, 2023
nunogois
force-pushed
the
task/multipleRolesGroups
branch
from
b54295b
to
fdf6f96
Compare
chriswk
commented
Aug 25, 2023
| cy.get(`[data-testid='${PA_ASSIGN_CREATE_ID}']`).click(); | ||
| cy.wait('@editAccess'); | ||
| cy.get("td span:contains('Owner')").should('have.length', 2); | ||
| cy.get("td span:contains('2 roles')").should('have.length', 1); |
There was a problem hiding this comment.
👍 , actual readable tests.
chriswk
commented
Aug 25, 2023
Comment on lines
+449
to
+465
| <MultipleRoleSelect | ||
| data-testid={PA_ROLE_ID} | ||
| roles={roles} | ||
| value={selectedRoles} | ||
| setValue={setRoles} | ||
| /> | ||
| )} | ||
| elseShow={() => ( | ||
| <RoleSelect | ||
| data-testid={PA_ROLE_ID} | ||
| roles={roles} | ||
| value={selectedRoles[0]} | ||
| setValue={role => | ||
| setRoles(role ? [role] : []) | ||
| } | ||
| /> | ||
| )} |
There was a problem hiding this comment.
Nice way of using the flag to turn it on/off :)
chriswk
commented
Aug 25, 2023
Comment on lines
-162
to
+142
| try { | ||
| const res = await makeRequest(req.caller, req.id); | ||
|
|
||
| return res; | ||
| } catch (e) { | ||
| throw e; | ||
| } | ||
| return await makeRequest(req.caller, req.id); |
There was a problem hiding this comment.
Good boyscouting here, why try-catch when we're just rethrowing :)
nunogois
approved these changes
Aug 25, 2023
nunogois
added a commit
that referenced
this pull request
Sep 5, 2023
Does what it says on the tin, should help with cleaning up #4512 and respective schema changes. --------- Co-authored-by: Gastón Fournier <gaston@getunleash.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1128/change-the-api-to-support-adding-multiple-roles-to-a-usergroup-on-a
https://linear.app/unleash/issue/2-1125/be-able-to-fetch-all-roles-for-a-user-in-a-project
https://linear.app/unleash/issue/2-1127/adapt-the-ui-to-be-able-to-do-a-multi-select-on-role-permissions-for
useProjectApito new methods that use new endpoints that support multiple rolesmultipleRolesfeature flag that controls the possibility of selecting multiple roles on the UIProjectAccessAssignto support multiple role, using the new methodsMultipleRoleSelectcomponent that allows you to select multiple roles based on theRoleSelectcomponentRoleCellcomponent to support either a single role or multiple rolesaccess.spec.tsCypress e2e test to reflect our new logicaccess-service.e2e.test.tswith tests covering the multiple roles logic and covering some corner casesproject-service.e2e.test.tsto adapt to the new logic, adding a test that covers adding access with[roles], [groups], [users]